package store import ( "context" "fmt" "io/fs" "reflect" "slices" "strings" "testing" "testing/fstest" "time" "code.cubecraftlabs.com/Maniacs_Mansion/Meal-Quest/migrations" ) var testMigrations = fstest.MapFS{ "0001_first.sql": {Data: []byte("CREATE TABLE first (id INTEGER PRIMARY KEY);")}, "0002_second.sql": {Data: []byte("CREATE TABLE second (id INTEGER PRIMARY KEY);\nCREATE TABLE third (id INTEGER PRIMARY KEY);")}, "README.md": {Data: []byte("not a migration")}, } type migrationRow struct { version string appliedAt string } func migrationRows(t *testing.T, s *Store) []migrationRow { t.Helper() rows, err := s.Reader.Query("SELECT version, applied_at FROM schema_migrations ORDER BY version") if err != nil { t.Fatal(err) } defer rows.Close() var out []migrationRow for rows.Next() { var r migrationRow if err := rows.Scan(&r.version, &r.appliedAt); err != nil { t.Fatal(err) } out = append(out, r) } if err := rows.Err(); err != nil { t.Fatal(err) } return out } func versions(rows []migrationRow) string { vs := make([]string, len(rows)) for i, r := range rows { vs[i] = r.version } return strings.Join(vs, ",") } func tableExists(t *testing.T, s *Store, name string) bool { t.Helper() var n int if err := s.Reader.QueryRow("SELECT count(*) FROM sqlite_schema WHERE type = 'table' AND name = ?", name).Scan(&n); err != nil { t.Fatal(err) } return n == 1 } func TestMigrateFreshDatabaseReachesLatest(t *testing.T) { s := openTestStore(t) if err := Migrate(context.Background(), s.Writer, testMigrations); err != nil { t.Fatal(err) } rows := migrationRows(t, s) if got := versions(rows); got != "0001_first,0002_second" { t.Fatalf("versions = %q", got) } for _, r := range rows { if _, err := time.Parse(time.RFC3339, r.appliedAt); err != nil || !strings.HasSuffix(r.appliedAt, "Z") { t.Errorf("applied_at %q is not UTC RFC 3339", r.appliedAt) } } for _, table := range []string{"first", "second", "third"} { if !tableExists(t, s, table) { t.Errorf("table %s missing", table) } } } func TestMigrateSecondRunIsNoOp(t *testing.T) { ctx := context.Background() s := openTestStore(t) if err := Migrate(ctx, s.Writer, testMigrations); err != nil { t.Fatal(err) } before := migrationRows(t, s) if err := Migrate(ctx, s.Writer, testMigrations); err != nil { t.Fatalf("second run: %v", err) } after := migrationRows(t, s) if len(after) != len(before) { t.Fatalf("rows after second run = %v, want %v", after, before) } for i := range before { if after[i] != before[i] { t.Errorf("row %d changed: %v -> %v", i, before[i], after[i]) } } } func TestMigrateBrokenMigrationRollsBack(t *testing.T) { ctx := context.Background() s := openTestStore(t) if err := Migrate(ctx, s.Writer, testMigrations); err != nil { t.Fatal(err) } broken := fstest.MapFS{"0003_broken.sql": {Data: []byte( // The first statement succeeds; the second is invalid, so the // table created by the first must be rolled back with it. "CREATE TABLE fourth (id INTEGER PRIMARY KEY);\nCREATE TABLE oops (;", )}} for name, f := range testMigrations { broken[name] = f } err := Migrate(ctx, s.Writer, broken) if err == nil { t.Fatal("broken migration returned no error") } if !strings.Contains(err.Error(), "0003_broken.sql") { t.Errorf("error %q does not name the failing migration", err) } if got := versions(migrationRows(t, s)); got != "0001_first,0002_second" { t.Errorf("versions after failure = %q, want previous version intact", got) } if tableExists(t, s, "fourth") { t.Error("table from the failed migration was not rolled back") } for _, table := range []string{"first", "second", "third"} { if !tableExists(t, s, table) { t.Errorf("previous table %s missing after failed migration", table) } } } func TestMigrateAppliesInFilenameOrder(t *testing.T) { s := openTestStore(t) // 0002 depends on 0001; MapFS iteration order is random, so this only // passes if migrations are sorted by name. ordered := fstest.MapFS{ "0002_child.sql": {Data: []byte("CREATE TABLE child (parent_id INTEGER REFERENCES parent(id)); INSERT INTO child VALUES (1);")}, "0001_parent.sql": {Data: []byte("CREATE TABLE parent (id INTEGER PRIMARY KEY); INSERT INTO parent VALUES (1);")}, } if err := Migrate(context.Background(), s.Writer, ordered); err != nil { t.Fatal(err) } } func TestMigrateUnknownAppliedVersionFails(t *testing.T) { ctx := context.Background() s := openTestStore(t) if err := Migrate(ctx, s.Writer, testMigrations); err != nil { t.Fatal(err) } older := fstest.MapFS{"0001_first.sql": testMigrations["0001_first.sql"]} if err := Migrate(ctx, s.Writer, older); err == nil { t.Fatal("migrating a database newer than the build returned no error") } } func TestMigrateNoMigrationsFails(t *testing.T) { s := openTestStore(t) if err := Migrate(context.Background(), s.Writer, fstest.MapFS{}); err == nil { t.Fatal("empty migrations returned no error") } } func TestMigrateEmbeddedMigrations(t *testing.T) { s := openTestStore(t) if err := Migrate(context.Background(), s.Writer, migrations.FS); err != nil { t.Fatal(err) } if got := versions(migrationRows(t, s)); got != "0000_bootstrap,0001_init,0002_household_settings_updated_by,0003_jobs_status,0004_ai_provider_presets,0005_ai_provider_xai,0006_ai_runs_status,0007_recipe_grounding,0008_dinner_recipe_url,0009_dinner_grounding_error,0010_dinner_grounding_revision,0011_ground_dinner_job_revision,0012_suggestion_name,0013_week_plan_revision,0014_rotation_review_name,0015_google_reconnect_required,0016_shopping_list_untitled,0017_shopping_list_chat_send_unconfirmed,0018_recipe_item_position_unique,0019_shopping_group_frozen_name,0020_site_name_from_page" { t.Errorf("versions = %q, want 0000_bootstrap,0001_init,0002_household_settings_updated_by,0003_jobs_status,0004_ai_provider_presets,0005_ai_provider_xai,0006_ai_runs_status,0007_recipe_grounding,0008_dinner_recipe_url,0009_dinner_grounding_error,0010_dinner_grounding_revision,0011_ground_dinner_job_revision,0012_suggestion_name,0013_week_plan_revision,0014_rotation_review_name,0015_google_reconnect_required,0016_shopping_list_untitled,0017_shopping_list_chat_send_unconfirmed,0018_recipe_item_position_unique,0019_shopping_group_frozen_name,0020_site_name_from_page", got) } } func TestMigrateBootstrapThenEmbeddedInitApplies(t *testing.T) { ctx := context.Background() s := openTestStore(t) bootstrap, err := fs.ReadFile(migrations.FS, "0000_bootstrap.sql") if err != nil { t.Fatal(err) } // A database migrated by the bootstrap-only build upgrades to the // embedded set, which adds the later migrations alongside the unchanged // bootstrap. if err := Migrate(ctx, s.Writer, fstest.MapFS{"0000_bootstrap.sql": {Data: bootstrap}}); err != nil { t.Fatal(err) } if err := Migrate(ctx, s.Writer, migrations.FS); err != nil { t.Fatal(err) } if got := versions(migrationRows(t, s)); got != "0000_bootstrap,0001_init,0002_household_settings_updated_by,0003_jobs_status,0004_ai_provider_presets,0005_ai_provider_xai,0006_ai_runs_status,0007_recipe_grounding,0008_dinner_recipe_url,0009_dinner_grounding_error,0010_dinner_grounding_revision,0011_ground_dinner_job_revision,0012_suggestion_name,0013_week_plan_revision,0014_rotation_review_name,0015_google_reconnect_required,0016_shopping_list_untitled,0017_shopping_list_chat_send_unconfirmed,0018_recipe_item_position_unique,0019_shopping_group_frozen_name,0020_site_name_from_page" { t.Errorf("versions = %q, want 0000_bootstrap,0001_init,0002_household_settings_updated_by,0003_jobs_status,0004_ai_provider_presets,0005_ai_provider_xai,0006_ai_runs_status,0007_recipe_grounding,0008_dinner_recipe_url,0009_dinner_grounding_error,0010_dinner_grounding_revision,0011_ground_dinner_job_revision,0012_suggestion_name,0013_week_plan_revision,0014_rotation_review_name,0015_google_reconnect_required,0016_shopping_list_untitled,0017_shopping_list_chat_send_unconfirmed,0018_recipe_item_position_unique,0019_shopping_group_frozen_name,0020_site_name_from_page", got) } if !tableExists(t, s, "dinners") { t.Error("table from 0001_init was not created") } } // schemaSQL returns every schema object's definition, so a test can prove a // later Migrate created or altered nothing. func schemaSQL(t *testing.T, s *Store) []string { t.Helper() rows, err := s.Reader.Query("SELECT type || ' ' || name || ': ' || coalesce(sql, '') FROM sqlite_schema ORDER BY type, name") if err != nil { t.Fatal(err) } defer rows.Close() var out []string for rows.Next() { var def string if err := rows.Scan(&def); err != nil { t.Fatal(err) } out = append(out, def) } if err := rows.Err(); err != nil { t.Fatal(err) } return out } func TestMigrateReopenSameDataDirIsNoOp(t *testing.T) { ctx := context.Background() dir := t.TempDir() first, err := Open(ctx, dir) if err != nil { t.Fatal(err) } if err := Migrate(ctx, first.Writer, migrations.FS); err != nil { t.Fatal(err) } before, beforeSchema := migrationRows(t, first), schemaSQL(t, first) if err := first.Close(); err != nil { t.Fatal(err) } second, err := Open(ctx, dir) if err != nil { t.Fatalf("reopen: %v", err) } t.Cleanup(func() { if err := second.Close(); err != nil { t.Error(err) } }) if err := Migrate(ctx, second.Writer, migrations.FS); err != nil { t.Fatalf("migrate after reopen: %v", err) } if after := migrationRows(t, second); !slices.Equal(after, before) { t.Errorf("schema_migrations changed on reopen:\n got %v\nwant %v", after, before) } if afterSchema := schemaSQL(t, second); !slices.Equal(afterSchema, beforeSchema) { t.Errorf("schema changed on reopen:\n got %v\nwant %v", afterSchema, beforeSchema) } } // TestMigrateJobsStatusMapsLegacyRows upgrades a database holding jobs in // every 0001 status and checks 0003 carries each row over with its status // mapped and every other column unchanged. func TestMigrateJobsStatusMapsLegacyRows(t *testing.T) { ctx := context.Background() s := openTestStore(t) before := fstest.MapFS{} for _, name := range []string{"0000_bootstrap.sql", "0001_init.sql", "0002_household_settings_updated_by.sql"} { body, err := fs.ReadFile(migrations.FS, name) if err != nil { t.Fatal(err) } before[name] = &fstest.MapFile{Data: body} } if err := Migrate(ctx, s.Writer, before); err != nil { t.Fatal(err) } legacy := map[string]string{"pending": "queued", "running": "running", "done": "succeeded", "failed": "failed"} for old := range legacy { if _, err := s.Writer.Exec(`INSERT INTO jobs (id, kind, status, payload, result, error, started_at, finished_at, created_at, updated_at) VALUES (?, 'suggest', ?, '{"n":1}', '{"r":2}', 'boom', 's', 'f', 'c', 'u')`, "job-"+old, old); err != nil { t.Fatalf("insert %s job: %v", old, err) } } if err := Migrate(ctx, s.Writer, migrations.FS); err != nil { t.Fatal(err) } for old, want := range legacy { var kind, status, payload, result, errText, startedAt, finishedAt, createdAt, updatedAt string if err := s.Reader.QueryRow(`SELECT kind, status, payload, result, error, started_at, finished_at, created_at, updated_at FROM jobs WHERE id = ?`, "job-"+old). Scan(&kind, &status, &payload, &result, &errText, &startedAt, &finishedAt, &createdAt, &updatedAt); err != nil { t.Fatalf("read %s job: %v", old, err) } if status != want { t.Errorf("%s job status = %q, want %q", old, status, want) } got := []string{kind, payload, result, errText, startedAt, finishedAt, createdAt, updatedAt} if wantCols := []string{"suggest", `{"n":1}`, `{"r":2}`, "boom", "s", "f", "c", "u"}; !slices.Equal(got, wantCols) { t.Errorf("%s job columns = %v, want %v", old, got, wantCols) } } if tableExists(t, s, "jobs_new") { t.Error("jobs_new left behind") } } // TestMigrateAIProviderPresetsKeepsRowsAndReferences upgrades a database // holding ai_settings and ai_runs rows, with suggestion_batches and // week_plans referencing the run, and checks 0004 carries every row over, // keeps the references enforced and accepts the new providers. func TestMigrateAIProviderPresetsKeepsRowsAndReferences(t *testing.T) { ctx := context.Background() s := openTestStore(t) before := fstest.MapFS{} for _, name := range []string{"0000_bootstrap.sql", "0001_init.sql", "0002_household_settings_updated_by.sql", "0003_jobs_status.sql"} { body, err := fs.ReadFile(migrations.FS, name) if err != nil { t.Fatal(err) } before[name] = &fstest.MapFile{Data: body} } if err := Migrate(ctx, s.Writer, before); err != nil { t.Fatal(err) } for _, stmt := range []string{ `INSERT INTO ai_settings (id, provider, base_url, model, temperature, system_prompt, api_key_ct, api_key_last4, key_verified_at, created_at, updated_at) VALUES (1, 'anthropic', 'https://api.anthropic.com', 'claude', 0.7, 'sp', x'0102', 'abcd', 'v', 'c', 'u')`, `INSERT INTO ai_runs (id, skill, skill_version, provider, model, temperature, status, latency_ms, tokens_in, tokens_out, error, request_redacted, response_redacted, created_at, updated_at) VALUES ('run-1', 'suggest', '1', 'ollama', 'llama', 0.5, 'ok', 10, 20, 30, 'e', 'req', 'resp', 'c', 'u')`, `INSERT INTO suggestion_batches (id, trigger, status, ai_run_id, created_at, updated_at) VALUES ('batch-1', 'manual', 'done', 'run-1', 'c', 'u')`, `INSERT INTO week_plans (id, week_start, status, ai_run_id, created_at, updated_at) VALUES ('plan-1', '2026-10-04', 'draft', 'run-1', 'c', 'u')`, } { if _, err := s.Writer.Exec(stmt); err != nil { t.Fatalf("seed: %v", err) } } if err := Migrate(ctx, s.Writer, migrations.FS); err != nil { t.Fatal(err) } var provider, baseURL, model, systemPrompt, last4, verifiedAt, createdAt, updatedAt string var temperature float64 var keyCT []byte if err := s.Reader.QueryRow(`SELECT provider, base_url, model, temperature, system_prompt, api_key_ct, api_key_last4, key_verified_at, created_at, updated_at FROM ai_settings WHERE id = 1`). Scan(&provider, &baseURL, &model, &temperature, &systemPrompt, &keyCT, &last4, &verifiedAt, &createdAt, &updatedAt); err != nil { t.Fatalf("read ai_settings: %v", err) } settings := []any{provider, baseURL, model, temperature, systemPrompt, string(keyCT), last4, verifiedAt, createdAt, updatedAt} if want := []any{"anthropic", "https://api.anthropic.com", "claude", 0.7, "sp", "\x01\x02", "abcd", "v", "c", "u"}; !slices.Equal(settings, want) { t.Errorf("ai_settings = %v, want %v", settings, want) } var skill, skillVersion, status, errText, request, response string var latency, tokensIn, tokensOut int if err := s.Reader.QueryRow(`SELECT skill, skill_version, provider, model, temperature, status, latency_ms, tokens_in, tokens_out, error, request_redacted, response_redacted, created_at, updated_at FROM ai_runs WHERE id = 'run-1'`). Scan(&skill, &skillVersion, &provider, &model, &temperature, &status, &latency, &tokensIn, &tokensOut, &errText, &request, &response, &createdAt, &updatedAt); err != nil { t.Fatalf("read ai_runs: %v", err) } run := []any{skill, skillVersion, provider, model, temperature, status, latency, tokensIn, tokensOut, errText, request, response, createdAt, updatedAt} if want := []any{"suggest", "1", "ollama", "llama", 0.5, "ok", 10, 20, 30, "e", "req", "resp", "c", "u"}; !slices.Equal(run, want) { t.Errorf("ai_runs = %v, want %v", run, want) } rows, err := s.Reader.Query("PRAGMA foreign_key_check") if err != nil { t.Fatal(err) } if rows.Next() { t.Error("foreign_key_check reported violations after 0004") } if err := rows.Close(); err != nil { t.Fatal(err) } if _, err := s.Writer.Exec(`DELETE FROM ai_runs WHERE id = 'run-1'`); err == nil || !strings.Contains(err.Error(), "FOREIGN KEY constraint failed") { t.Errorf("deleting a referenced ai_run: error %v, want FOREIGN KEY constraint failure", err) } if _, err := s.Writer.Exec(`UPDATE ai_settings SET provider = 'openrouter' WHERE id = 1`); err != nil { t.Errorf("ai_settings.provider openrouter rejected: %v", err) } if _, err := s.Writer.Exec(`UPDATE ai_runs SET provider = 'openai' WHERE id = 'run-1'`); err != nil { t.Errorf("ai_runs.provider openai rejected: %v", err) } for _, table := range []string{"ai_settings_copy", "ai_runs_copy"} { if tableExists(t, s, table) { t.Errorf("%s left behind", table) } } } // TestMigrateAIProviderXAIKeepsRowsAndReferences upgrades a database at 0004 // holding ai_settings and ai_runs rows with 0004's providers, with // suggestion_batches and week_plans referencing the run, and checks 0005 // carries every row over, keeps the references enforced, accepts xai and // still rejects an unknown provider. func TestMigrateAIProviderXAIKeepsRowsAndReferences(t *testing.T) { ctx := context.Background() s := openTestStore(t) before := fstest.MapFS{} for _, name := range []string{"0000_bootstrap.sql", "0001_init.sql", "0002_household_settings_updated_by.sql", "0003_jobs_status.sql", "0004_ai_provider_presets.sql"} { body, err := fs.ReadFile(migrations.FS, name) if err != nil { t.Fatal(err) } before[name] = &fstest.MapFile{Data: body} } if err := Migrate(ctx, s.Writer, before); err != nil { t.Fatal(err) } for _, stmt := range []string{ `INSERT INTO ai_settings (id, provider, base_url, model, temperature, system_prompt, api_key_ct, api_key_last4, key_verified_at, created_at, updated_at) VALUES (1, 'openrouter', 'https://openrouter.ai/api/v1', 'openai/gpt-4o', 0.7, 'sp', x'0102', 'abcd', 'v', 'c', 'u')`, `INSERT INTO ai_runs (id, skill, skill_version, provider, model, temperature, status, latency_ms, tokens_in, tokens_out, error, request_redacted, response_redacted, created_at, updated_at) VALUES ('run-1', 'suggest', '1', 'openai', 'gpt-4o', 0.5, 'ok', 10, 20, 30, 'e', 'req', 'resp', 'c', 'u')`, `INSERT INTO suggestion_batches (id, trigger, status, ai_run_id, created_at, updated_at) VALUES ('batch-1', 'manual', 'done', 'run-1', 'c', 'u')`, `INSERT INTO week_plans (id, week_start, status, ai_run_id, created_at, updated_at) VALUES ('plan-1', '2026-10-04', 'draft', 'run-1', 'c', 'u')`, } { if _, err := s.Writer.Exec(stmt); err != nil { t.Fatalf("seed: %v", err) } } if err := Migrate(ctx, s.Writer, migrations.FS); err != nil { t.Fatal(err) } var provider, baseURL, model, systemPrompt, last4, verifiedAt, createdAt, updatedAt string var temperature float64 var keyCT []byte if err := s.Reader.QueryRow(`SELECT provider, base_url, model, temperature, system_prompt, api_key_ct, api_key_last4, key_verified_at, created_at, updated_at FROM ai_settings WHERE id = 1`). Scan(&provider, &baseURL, &model, &temperature, &systemPrompt, &keyCT, &last4, &verifiedAt, &createdAt, &updatedAt); err != nil { t.Fatalf("read ai_settings: %v", err) } settings := []any{provider, baseURL, model, temperature, systemPrompt, string(keyCT), last4, verifiedAt, createdAt, updatedAt} if want := []any{"openrouter", "https://openrouter.ai/api/v1", "openai/gpt-4o", 0.7, "sp", "\x01\x02", "abcd", "v", "c", "u"}; !slices.Equal(settings, want) { t.Errorf("ai_settings = %v, want %v", settings, want) } var skill, skillVersion, status, errText, request, response string var latency, tokensIn, tokensOut int if err := s.Reader.QueryRow(`SELECT skill, skill_version, provider, model, temperature, status, latency_ms, tokens_in, tokens_out, error, request_redacted, response_redacted, created_at, updated_at FROM ai_runs WHERE id = 'run-1'`). Scan(&skill, &skillVersion, &provider, &model, &temperature, &status, &latency, &tokensIn, &tokensOut, &errText, &request, &response, &createdAt, &updatedAt); err != nil { t.Fatalf("read ai_runs: %v", err) } run := []any{skill, skillVersion, provider, model, temperature, status, latency, tokensIn, tokensOut, errText, request, response, createdAt, updatedAt} if want := []any{"suggest", "1", "openai", "gpt-4o", 0.5, "ok", 10, 20, 30, "e", "req", "resp", "c", "u"}; !slices.Equal(run, want) { t.Errorf("ai_runs = %v, want %v", run, want) } rows, err := s.Reader.Query("PRAGMA foreign_key_check") if err != nil { t.Fatal(err) } if rows.Next() { t.Error("foreign_key_check reported violations after 0005") } if err := rows.Close(); err != nil { t.Fatal(err) } if _, err := s.Writer.Exec(`DELETE FROM ai_runs WHERE id = 'run-1'`); err == nil || !strings.Contains(err.Error(), "FOREIGN KEY constraint failed") { t.Errorf("deleting a referenced ai_run: error %v, want FOREIGN KEY constraint failure", err) } for _, table := range []string{"ai_settings", "ai_runs"} { if _, err := s.Writer.Exec(`UPDATE ` + table + ` SET provider = 'xai'`); err != nil { t.Errorf("%s.provider xai rejected: %v", table, err) } if _, err := s.Writer.Exec(`UPDATE ` + table + ` SET provider = 'grok'`); err == nil || !strings.Contains(err.Error(), "CHECK constraint failed") { t.Errorf("%s.provider grok: error %v, want CHECK constraint failure", table, err) } } for _, table := range []string{"ai_settings_copy", "ai_runs_copy"} { if tableExists(t, s, table) { t.Errorf("%s left behind", table) } } } // TestMigrateAIRunsStatus upgrades a database at 0005 and checks 0006 // keeps an ok run and its references, accepts every harness outcome, and // stops on a run with a pre-harness status rather than guess its outcome. func TestMigrateAIRunsStatus(t *testing.T) { ctx := context.Background() before := fstest.MapFS{} for _, name := range []string{"0000_bootstrap.sql", "0001_init.sql", "0002_household_settings_updated_by.sql", "0003_jobs_status.sql", "0004_ai_provider_presets.sql", "0005_ai_provider_xai.sql"} { body, err := fs.ReadFile(migrations.FS, name) if err != nil { t.Fatal(err) } before[name] = &fstest.MapFile{Data: body} } seedRun := func(t *testing.T, s *Store, status string) { t.Helper() if err := Migrate(ctx, s.Writer, before); err != nil { t.Fatal(err) } for _, stmt := range []string{ `INSERT INTO ai_runs (id, skill, skill_version, provider, model, temperature, status, latency_ms, tokens_in, tokens_out, error, request_redacted, response_redacted, created_at, updated_at) VALUES ('run-1', 'suggest', '1', 'xai', 'grok', 0.5, '` + status + `', 10, 20, 30, 'e', 'req', 'resp', 'c', 'u')`, `INSERT INTO suggestion_batches (id, trigger, status, ai_run_id, created_at, updated_at) VALUES ('batch-1', 'manual', 'done', 'run-1', 'c', 'u')`, } { if _, err := s.Writer.Exec(stmt); err != nil { t.Fatalf("seed: %v", err) } } } t.Run("ok row kept", func(t *testing.T) { s := openTestStore(t) seedRun(t, s, "ok") if err := Migrate(ctx, s.Writer, migrations.FS); err != nil { t.Fatal(err) } var status, request string if err := s.Reader.QueryRow(`SELECT status, request_redacted FROM ai_runs WHERE id = 'run-1'`).Scan(&status, &request); err != nil { t.Fatal(err) } if status != "ok" || request != "req" { t.Errorf("ai_runs row = %s, %s; want ok, req", status, request) } if _, err := s.Writer.Exec(`DELETE FROM ai_runs WHERE id = 'run-1'`); err == nil || !strings.Contains(err.Error(), "FOREIGN KEY constraint failed") { t.Errorf("deleting a referenced ai_run: error %v, want FOREIGN KEY constraint failure", err) } for _, status := range []string{"repaired", "bad_output", "provider_error", "ok"} { if _, err := s.Writer.Exec(`UPDATE ai_runs SET status = ? WHERE id = 'run-1'`, status); err != nil { t.Errorf("ai_runs.status %s rejected: %v", status, err) } } if tableExists(t, s, "ai_runs_copy") { t.Error("ai_runs_copy left behind") } }) for _, legacy := range []string{"running", "error"} { t.Run(legacy+" row stops the migration", func(t *testing.T) { s := openTestStore(t) seedRun(t, s, legacy) if err := Migrate(ctx, s.Writer, migrations.FS); err == nil || !strings.Contains(err.Error(), "CHECK constraint failed") { t.Fatalf("Migrate error = %v, want a CHECK constraint failure", err) } var status string if err := s.Reader.QueryRow(`SELECT status FROM ai_runs WHERE id = 'run-1'`).Scan(&status); err != nil || status != legacy { t.Errorf("after the failed migration status = %q, %v; want %q kept", status, err, legacy) } }) } } // TestMigrateSuggestionName upgrades a database at 0011 holding a pending // and a declined suggestion and checks 0012 keeps both, gives each its // dinner's name, and refuses a suggestion with no name. func TestMigrateSuggestionName(t *testing.T) { ctx := context.Background() s := openTestStore(t) before := fstest.MapFS{} for _, name := range []string{ "0000_bootstrap.sql", "0001_init.sql", "0002_household_settings_updated_by.sql", "0003_jobs_status.sql", "0004_ai_provider_presets.sql", "0005_ai_provider_xai.sql", "0006_ai_runs_status.sql", "0007_recipe_grounding.sql", "0008_dinner_recipe_url.sql", "0009_dinner_grounding_error.sql", "0010_dinner_grounding_revision.sql", "0011_ground_dinner_job_revision.sql", } { body, err := fs.ReadFile(migrations.FS, name) if err != nil { t.Fatal(err) } before[name] = &fstest.MapFile{Data: body} } if err := Migrate(ctx, s.Writer, before); err != nil { t.Fatal(err) } for _, stmt := range []string{ `INSERT INTO dinners (id, name, normalized_name, status, origin, is_favorite, grounding_status, created_at, updated_at) VALUES ('dinner-1', 'Pho', 'pho', 'suggested', 'side_quest', 0, 'grounded', 'c', 'u'), ('dinner-2', 'Ramen', 'ramen', 'archived', 'side_quest', 0, 'grounded', 'c', 'u')`, `INSERT INTO suggestion_batches (id, trigger, status, created_at, updated_at) VALUES ('batch-1', 'manual', 'done', 'c', 'u')`, `INSERT INTO suggestions (id, dinner_id, batch_id, reason, cited_regular_ids, status, decided_at, created_at, updated_at) VALUES ('sugg-1', 'dinner-1', 'batch-1', 'why 1', '[]', 'pending', NULL, 'c1', 'u1'), ('sugg-2', 'dinner-2', 'batch-1', 'why 2', '["dinner-1"]', 'declined', 'd2', 'c2', 'u2')`, } { if _, err := s.Writer.Exec(stmt); err != nil { t.Fatalf("seed: %v", err) } } if err := Migrate(ctx, s.Writer, migrations.FS); err != nil { t.Fatal(err) } rows, err := s.Reader.Query(`SELECT id, dinner_id, batch_id, name, reason, cited_regular_ids, status, COALESCE(decided_at, ''), created_at, updated_at FROM suggestions ORDER BY id`) if err != nil { t.Fatal(err) } var got [][]string for rows.Next() { r := make([]string, 10) if err := rows.Scan(&r[0], &r[1], &r[2], &r[3], &r[4], &r[5], &r[6], &r[7], &r[8], &r[9]); err != nil { t.Fatal(err) } got = append(got, r) } if err := rows.Close(); err != nil { t.Fatal(err) } want := [][]string{ {"sugg-1", "dinner-1", "batch-1", "Pho", "why 1", "[]", "pending", "", "c1", "u1"}, {"sugg-2", "dinner-2", "batch-1", "Ramen", "why 2", `["dinner-1"]`, "declined", "d2", "c2", "u2"}, } if !reflect.DeepEqual(got, want) { t.Errorf("suggestions after 0012 =\n %v\nwant\n %v", got, want) } if _, err := s.Writer.Exec(`UPDATE suggestions SET name = '' WHERE id = 'sugg-1'`); err == nil || !strings.Contains(err.Error(), "CHECK constraint failed") { t.Errorf("empty suggestion name: error %v, want CHECK constraint failure", err) } if _, err := s.Writer.Exec(`UPDATE suggestions SET dinner_id = 'nope' WHERE id = 'sugg-1'`); err == nil || !strings.Contains(err.Error(), "FOREIGN KEY constraint failed") { t.Errorf("unknown dinner: error %v, want FOREIGN KEY constraint failure", err) } if tableExists(t, s, "suggestions_copy") { t.Error("suggestions_copy left behind") } } // TestMigrateRotationReviewName upgrades a database at 0013 holding a // pending, a kept and a dropped Rotation check and checks 0014 keeps all // three, gives only the drop its dinner's name, and refuses a drop with no // name or a name on any other check. func TestMigrateRotationReviewName(t *testing.T) { ctx := context.Background() s := openTestStore(t) before := fstest.MapFS{} for _, name := range []string{ "0000_bootstrap.sql", "0001_init.sql", "0002_household_settings_updated_by.sql", "0003_jobs_status.sql", "0004_ai_provider_presets.sql", "0005_ai_provider_xai.sql", "0006_ai_runs_status.sql", "0007_recipe_grounding.sql", "0008_dinner_recipe_url.sql", "0009_dinner_grounding_error.sql", "0010_dinner_grounding_revision.sql", "0011_ground_dinner_job_revision.sql", "0012_suggestion_name.sql", "0013_week_plan_revision.sql", } { body, err := fs.ReadFile(migrations.FS, name) if err != nil { t.Fatal(err) } before[name] = &fstest.MapFile{Data: body} } if err := Migrate(ctx, s.Writer, before); err != nil { t.Fatal(err) } for _, stmt := range []string{ `INSERT INTO dinners (id, name, normalized_name, status, origin, is_favorite, grounding_status, created_at, updated_at) VALUES ('dinner-1', 'Pho', 'pho', 'tried', 'side_quest', 0, 'grounded', 'c', 'u'), ('dinner-2', 'Ramen', 'ramen', 'regular', 'side_quest', 0, 'grounded', 'c', 'u'), ('dinner-3', 'Laksa', 'laksa', 'archived', 'side_quest', 0, 'grounded', 'c', 'u')`, `INSERT INTO rotation_reviews (id, dinner_id, plan_date, status, decision, decided_at, updated_by, created_at, updated_at) VALUES ('review-1', 'dinner-1', '2026-10-12', 'pending', NULL, NULL, NULL, 'c1', 'u1'), ('review-2', 'dinner-2', '2026-10-13', 'decided', 'keep', 'd2', 'member-1', 'c2', 'u2'), ('review-3', 'dinner-3', '2026-10-14', 'decided', 'drop', 'd3', 'member-1', 'c3', 'u3')`, } { if _, err := s.Writer.Exec(stmt); err != nil { t.Fatalf("seed: %v", err) } } if err := Migrate(ctx, s.Writer, migrations.FS); err != nil { t.Fatal(err) } rows, err := s.Reader.Query(`SELECT id, dinner_id, plan_date, status, COALESCE(decision, ''), COALESCE(name, ''), COALESCE(decided_at, ''), COALESCE(updated_by, ''), created_at, updated_at FROM rotation_reviews ORDER BY id`) if err != nil { t.Fatal(err) } var got [][]string for rows.Next() { r := make([]string, 10) if err := rows.Scan(&r[0], &r[1], &r[2], &r[3], &r[4], &r[5], &r[6], &r[7], &r[8], &r[9]); err != nil { t.Fatal(err) } got = append(got, r) } if err := rows.Close(); err != nil { t.Fatal(err) } want := [][]string{ {"review-1", "dinner-1", "2026-10-12", "pending", "", "", "", "", "c1", "u1"}, {"review-2", "dinner-2", "2026-10-13", "decided", "keep", "", "d2", "member-1", "c2", "u2"}, {"review-3", "dinner-3", "2026-10-14", "decided", "drop", "Laksa", "d3", "member-1", "c3", "u3"}, } if !reflect.DeepEqual(got, want) { t.Errorf("rotation_reviews after 0014 =\n %v\nwant\n %v", got, want) } for _, tc := range []struct{ name, stmt, want string }{ {"drop with no name", `UPDATE rotation_reviews SET name = NULL WHERE id = 'review-3'`, "CHECK constraint failed"}, {"empty name", `UPDATE rotation_reviews SET name = '' WHERE id = 'review-3'`, "CHECK constraint failed"}, {"name on a keep", `UPDATE rotation_reviews SET name = 'Ramen' WHERE id = 'review-2'`, "CHECK constraint failed"}, {"name on a pending check", `UPDATE rotation_reviews SET name = 'Pho' WHERE id = 'review-1'`, "CHECK constraint failed"}, {"unknown dinner", `UPDATE rotation_reviews SET dinner_id = 'nope' WHERE id = 'review-1'`, "FOREIGN KEY constraint failed"}, {"second check of a dinner and date", `INSERT INTO rotation_reviews (id, dinner_id, plan_date, status, created_at, updated_at) VALUES ('review-4', 'dinner-1', '2026-10-12', 'pending', 'c', 'u')`, "UNIQUE constraint failed"}, } { if _, err := s.Writer.Exec(tc.stmt); err == nil || !strings.Contains(err.Error(), tc.want) { t.Errorf("%s: error %v, want %s", tc.name, err, tc.want) } } if tableExists(t, s, "rotation_reviews_copy") { t.Error("rotation_reviews_copy left behind") } } // TestMigrateGoogleReconnectKeepsConnection applies 0015, which rebuilds // integrations_google, over a stored connection: every column survives. func TestMigrateGoogleReconnectKeepsConnection(t *testing.T) { ctx := context.Background() s := openTestStore(t) before := fstest.MapFS{} matches, err := fs.Glob(migrations.FS, "*.sql") if err != nil { t.Fatal(err) } for _, name := range matches { if name >= "0015" { continue } body, err := fs.ReadFile(migrations.FS, name) if err != nil { t.Fatal(err) } before[name] = &fstest.MapFile{Data: body} } if err := Migrate(ctx, s.Writer, before); err != nil { t.Fatal(err) } const row = `1|token|family@group.calendar.google.com|Family|2026-10-01T00:00:00.000Z|earlier error|2026-09-01T00:00:00.000Z|2026-10-02T00:00:00.000Z` if _, err := s.Writer.ExecContext(ctx, `INSERT INTO integrations_google VALUES (1, CAST('token' AS BLOB), 'family@group.calendar.google.com', 'Family', '2026-10-01T00:00:00.000Z', 'earlier error', '2026-09-01T00:00:00.000Z', '2026-10-02T00:00:00.000Z')`); err != nil { t.Fatal(err) } if err := Migrate(ctx, s.Writer, migrations.FS); err != nil { t.Fatal(err) } var got string if err := s.Reader.QueryRowContext(ctx, `SELECT id || '|' || CAST(refresh_token_ct AS TEXT) || '|' || calendar_id || '|' || calendar_name || '|' || connected_at || '|' || last_sync_error || '|' || created_at || '|' || updated_at FROM integrations_google`).Scan(&got); err != nil { t.Fatal(err) } if got != row { t.Errorf("connection after 0015 = %s, want %s", got, row) } } // migrateBefore applies every migration whose name sorts before prefix. func migrateBefore(t *testing.T, s *Store, prefix string) { t.Helper() before := fstest.MapFS{} matches, err := fs.Glob(migrations.FS, "*.sql") if err != nil { t.Fatal(err) } for _, name := range matches { if name >= prefix { continue } body, err := fs.ReadFile(migrations.FS, name) if err != nil { t.Fatal(err) } before[name] = &fstest.MapFile{Data: body} } if err := Migrate(context.Background(), s.Writer, before); err != nil { t.Fatal(err) } } // seedShopping stores two dinners, a plan with dinner-1 on 2026-10-13 // and dinner-2 on 2026-10-14, and a titled list with a group of // groupDinner holding an item marked "have it". func seedShopping(t *testing.T, s *Store, groupDinner string) { t.Helper() for _, stmt := range []string{ `INSERT INTO dinners (id, name, normalized_name, status, origin, is_favorite, grounding_status, created_at, updated_at) VALUES ('dinner-1', 'Pho', 'pho', 'regular', 'regular', 0, 'grounded', 'c', 'u'), ('dinner-2', 'Ramen', 'ramen', 'regular', 'regular', 0, 'grounded', 'c', 'u'), ('dinner-3', 'Laksa', 'laksa', 'regular', 'regular', 0, 'grounded', 'c', 'u')`, `INSERT INTO week_plans (id, week_start, status, created_at, updated_at) VALUES ('plan-1', '2026-10-12', 'synced', 'c', 'u')`, `INSERT INTO plan_days (id, plan_id, date, dinner_id, is_new, created_at, updated_at) VALUES ('day-1', 'plan-1', '2026-10-13', 'dinner-1', 0, 'c', 'u'), ('day-2', 'plan-1', '2026-10-14', 'dinner-2', 0, 'c', 'u')`, `INSERT INTO shopping_lists (id, week_start, plan_id, title, status, sent_to_chat_at, frozen_at, created_at, updated_at) VALUES ('list-1', '2026-10-12', 'plan-1', 'Noodle week', 'current', 's', NULL, 'c1', 'u1')`, `INSERT INTO shopping_groups (id, list_id, dinner_id, position, created_at, updated_at) VALUES ('group-1', 'list-1', '` + groupDinner + `', 0, 'c2', 'u2')`, `INSERT INTO shopping_items (id, group_id, name, qty, needed, position, created_at, updated_at) VALUES ('item-1', 'group-1', 'rice noodles', '200 g', 0, 0, 'c3', 'u3')`, } { if _, err := s.Writer.Exec(stmt); err != nil { t.Fatalf("seed: %v", err) } } } // TestMigrateShoppingListUntitled applies 0016, which rebuilds the // shopping tables: every row survives, a group takes its dinner's plan // day, and a list may then be untitled but never have an empty title. func TestMigrateShoppingListUntitled(t *testing.T) { ctx := context.Background() s := openTestStore(t) migrateBefore(t, s, "0016") seedShopping(t, s, "dinner-2") if err := Migrate(ctx, s.Writer, migrations.FS); err != nil { t.Fatal(err) } var got string if err := s.Reader.QueryRowContext(ctx, `SELECT l.id || '|' || l.week_start || '|' || l.plan_id || '|' || l.title || '|' || l.status || '|' || l.sent_to_chat_at || '|' || COALESCE(l.frozen_at, '') || '|' || l.created_at || '|' || l.updated_at || ' / ' || g.id || '|' || g.list_id || '|' || g.dinner_id || '|' || g.date || '|' || g.position || '|' || g.created_at || '|' || g.updated_at || ' / ' || i.id || '|' || i.group_id || '|' || i.name || '|' || i.qty || '|' || i.needed || '|' || i.position || '|' || i.created_at || '|' || i.updated_at FROM shopping_lists l JOIN shopping_groups g ON g.list_id = l.id JOIN shopping_items i ON i.group_id = g.id`).Scan(&got); err != nil { t.Fatal(err) } const want = `list-1|2026-10-12|plan-1|Noodle week|current|s||c1|u1 / ` + `group-1|list-1|dinner-2|2026-10-14|0|c2|u2 / ` + `item-1|group-1|rice noodles|200 g|0|0|c3|u3` if got != want { t.Errorf("shopping rows after 0016 =\n %s\nwant\n %s", got, want) } if _, err := s.Writer.Exec(`UPDATE shopping_lists SET title = NULL WHERE id = 'list-1'`); err != nil { t.Errorf("untitled list refused: %v", err) } for _, tc := range []struct{ name, stmt, want string }{ {"empty title", `UPDATE shopping_lists SET title = '' WHERE id = 'list-1'`, "CHECK constraint failed"}, {"group with no date", `UPDATE shopping_groups SET date = NULL WHERE id = 'group-1'`, "NOT NULL constraint failed"}, {"group of an unknown list", `UPDATE shopping_groups SET list_id = 'nope' WHERE id = 'group-1'`, "FOREIGN KEY constraint failed"}, {"item of an unknown group", `UPDATE shopping_items SET group_id = 'nope' WHERE id = 'item-1'`, "FOREIGN KEY constraint failed"}, {"needed not a boolean", `UPDATE shopping_items SET needed = 2 WHERE id = 'item-1'`, "CHECK constraint failed"}, {"second list of a week", `INSERT INTO shopping_lists (id, week_start, plan_id, status, created_at, updated_at) VALUES ('list-2', '2026-10-12', 'plan-1', 'current', 'c', 'u')`, "UNIQUE constraint failed"}, } { if _, err := s.Writer.Exec(tc.stmt); err == nil || !strings.Contains(err.Error(), tc.want) { t.Errorf("%s: error %v, want %s", tc.name, err, tc.want) } } for _, table := range []string{"shopping_lists_copy", "shopping_groups_copy", "shopping_items_copy"} { if tableExists(t, s, table) { t.Errorf("%s left behind", table) } } } // TestMigrateShoppingListUntitledRefusesUndatedGroup applies 0016 over a // group whose dinner is not on its list's plan: it has no plan day, so the // migration fails and leaves the database as it was. func TestMigrateShoppingListUntitledRefusesUndatedGroup(t *testing.T) { ctx := context.Background() s := openTestStore(t) migrateBefore(t, s, "0016") seedShopping(t, s, "dinner-3") err := Migrate(ctx, s.Writer, migrations.FS) if err == nil || !strings.Contains(err.Error(), "NOT NULL constraint failed: shopping_groups.date") { t.Fatalf("Migrate = %v, want the undated group refused", err) } var n int if err := s.Reader.QueryRowContext(ctx, `SELECT count(*) FROM schema_migrations WHERE version = '0016_shopping_list_untitled'`).Scan(&n); err != nil { t.Fatal(err) } if n != 0 { t.Error("0016 recorded as applied") } if tableExists(t, s, "shopping_groups_copy") { t.Error("shopping_groups_copy left behind") } } // TestMigrateShoppingListChatSendUnconfirmed applies 0017 over a list // already sent: it keeps every value, and the list has no send // unconfirmed. func TestMigrateShoppingListChatSendUnconfirmed(t *testing.T) { ctx := context.Background() s := openTestStore(t) migrateBefore(t, s, "0017") for _, stmt := range []string{ `INSERT INTO week_plans (id, week_start, status, created_at, updated_at) VALUES ('plan-1', '2026-10-12', 'synced', 'c', 'u')`, `INSERT INTO shopping_lists (id, week_start, plan_id, title, status, sent_to_chat_at, frozen_at, created_at, updated_at) VALUES ('list-1', '2026-10-12', 'plan-1', 'Noodle week', 'current', 's', NULL, 'c1', 'u1')`, } { if _, err := s.Writer.Exec(stmt); err != nil { t.Fatalf("seed: %v", err) } } if err := Migrate(ctx, s.Writer, migrations.FS); err != nil { t.Fatal(err) } var got string if err := s.Reader.QueryRowContext(ctx, `SELECT id || '|' || title || '|' || status || '|' || sent_to_chat_at || '|' || COALESCE(chat_send_unconfirmed_at, 'NULL') || '|' || updated_at FROM shopping_lists`).Scan(&got); err != nil { t.Fatal(err) } if want := "list-1|Noodle week|current|s|NULL|u1"; got != want { t.Errorf("shopping list after 0017 = %s, want %s", got, want) } } // seedRecipeItems inserts two recipes, each with an ingredient and a step // at position 0, then the extra statements. func seedRecipeItems(t *testing.T, s *Store, extra ...string) { t.Helper() stmts := []string{ `INSERT INTO recipes (id, source_url, title, raw_jsonld, fetched_at, created_at, updated_at) VALUES ('recipe-1', 'https://example.com/chili', 'Chili', '{}', 'f', 'c', 'u')`, `INSERT INTO recipes (id, source_url, title, raw_jsonld, fetched_at, created_at, updated_at) VALUES ('recipe-2', 'https://example.com/curry', 'Curry', '{}', 'f', 'c', 'u')`, `INSERT INTO recipe_ingredients (id, recipe_id, position, raw_text, created_at, updated_at) VALUES ('ing-1', 'recipe-1', 0, '1 onion', 'c', 'u'), ('ing-2', 'recipe-2', 0, '1 lime', 'c', 'u')`, `INSERT INTO recipe_steps (id, recipe_id, position, text, created_at, updated_at) VALUES ('step-1', 'recipe-1', 0, 'Chop.', 'c', 'u'), ('step-2', 'recipe-2', 0, 'Squeeze.', 'c', 'u')`, } for _, stmt := range append(stmts, extra...) { if _, err := s.Writer.Exec(stmt); err != nil { t.Fatalf("seed: %v", err) } } } // TestMigrateRecipeItemPositionUnique applies 0018 over two recipes with // items at the same position: each recipe keeps its items, and a second // ingredient or step at a position its recipe already uses is refused. func TestMigrateRecipeItemPositionUnique(t *testing.T) { ctx := context.Background() s := openTestStore(t) migrateBefore(t, s, "0018") seedRecipeItems(t, s) if err := Migrate(ctx, s.Writer, migrations.FS); err != nil { t.Fatal(err) } var got string if err := s.Reader.QueryRowContext(ctx, `SELECT (SELECT group_concat(id || '@' || recipe_id || ':' || position, ',') FROM (SELECT * FROM recipe_ingredients ORDER BY id)) || ' / ' || (SELECT group_concat(id || '@' || recipe_id || ':' || position, ',') FROM (SELECT * FROM recipe_steps ORDER BY id))`).Scan(&got); err != nil { t.Fatal(err) } if want := "ing-1@recipe-1:0,ing-2@recipe-2:0 / step-1@recipe-1:0,step-2@recipe-2:0"; got != want { t.Errorf("recipe items after 0018 = %s, want %s", got, want) } for _, tc := range []struct{ name, stmt string }{ {"second ingredient at a position", `INSERT INTO recipe_ingredients (id, recipe_id, position, raw_text, created_at, updated_at) VALUES ('ing-3', 'recipe-1', 0, '2 onions', 'c', 'u')`}, {"second step at a position", `INSERT INTO recipe_steps (id, recipe_id, position, text, created_at, updated_at) VALUES ('step-3', 'recipe-1', 0, 'Dice.', 'c', 'u')`}, {"ingredient moved onto another's position", `UPDATE recipe_ingredients SET recipe_id = 'recipe-1' WHERE id = 'ing-2'`}, {"step moved onto another's position", `UPDATE recipe_steps SET recipe_id = 'recipe-1' WHERE id = 'step-2'`}, } { if _, err := s.Writer.Exec(tc.stmt); err == nil || !strings.Contains(err.Error(), "UNIQUE constraint failed") { t.Errorf("%s: error %v, want UNIQUE constraint failed", tc.name, err) } } } // TestMigrateRecipeItemPositionUniqueRefusesDuplicate applies 0018 over a // recipe already holding two ingredients, or two steps, at one position: // its order is unknown, so the migration fails and is not recorded. func TestMigrateRecipeItemPositionUniqueRefusesDuplicate(t *testing.T) { for _, tc := range []struct{ table, stmt string }{ {"recipe_ingredients", `INSERT INTO recipe_ingredients (id, recipe_id, position, raw_text, created_at, updated_at) VALUES ('ing-3', 'recipe-1', 0, '2 onions', 'c', 'u')`}, {"recipe_steps", `INSERT INTO recipe_steps (id, recipe_id, position, text, created_at, updated_at) VALUES ('step-3', 'recipe-1', 0, 'Dice.', 'c', 'u')`}, } { t.Run(tc.table, func(t *testing.T) { ctx := context.Background() s := openTestStore(t) migrateBefore(t, s, "0018") seedRecipeItems(t, s, tc.stmt) err := Migrate(ctx, s.Writer, migrations.FS) if err == nil || !strings.Contains(err.Error(), "UNIQUE constraint failed: "+tc.table+".recipe_id, "+tc.table+".position") { t.Fatalf("Migrate = %v, want the duplicate position refused", err) } var n int if err := s.Reader.QueryRowContext(ctx, `SELECT count(*) FROM schema_migrations WHERE version = '0018_recipe_item_position_unique'`).Scan(&n); err != nil { t.Fatal(err) } if n != 0 { t.Error("0018 recorded as applied") } }) } } // TestMigrateShoppingGroupFrozenName applies 0019 over a frozen list and // a current one: the frozen list's group takes its dinner's name now, the // current list's group has none, and a frozen name is never empty. func TestMigrateShoppingGroupFrozenName(t *testing.T) { ctx := context.Background() s := openTestStore(t) migrateBefore(t, s, "0019") for _, stmt := range []string{ `INSERT INTO dinners (id, name, normalized_name, status, origin, is_favorite, grounding_status, created_at, updated_at) VALUES ('dinner-1', 'Beef Stew', 'beef stew', 'regular', 'regular', 0, 'manual', 'c', 'u'), ('dinner-2', 'Lemon Chicken', 'lemon chicken', 'regular', 'regular', 0, 'manual', 'c', 'u')`, `INSERT INTO week_plans (id, week_start, status, created_at, updated_at) VALUES ('plan-1', '2026-10-05', 'synced', 'c', 'u'), ('plan-2', '2026-10-12', 'synced', 'c', 'u')`, `INSERT INTO shopping_lists (id, week_start, plan_id, status, frozen_at, created_at, updated_at) VALUES ('list-1', '2026-10-05', 'plan-1', 'archived', 'f', 'c', 'u'), ('list-2', '2026-10-12', 'plan-2', 'current', NULL, 'c', 'u')`, `INSERT INTO shopping_groups (id, list_id, dinner_id, date, position, created_at, updated_at) VALUES ('group-1', 'list-1', 'dinner-1', '2026-10-05', 0, 'c', 'u'), ('group-2', 'list-2', 'dinner-2', '2026-10-12', 0, 'c', 'u')`, } { if _, err := s.Writer.Exec(stmt); err != nil { t.Fatalf("seed: %v", err) } } if err := Migrate(ctx, s.Writer, migrations.FS); err != nil { t.Fatal(err) } rows, err := s.Reader.QueryContext(ctx, `SELECT id || '|' || COALESCE(frozen_dinner_name, 'NULL') || '|' || updated_at FROM shopping_groups ORDER BY id`) if err != nil { t.Fatal(err) } defer rows.Close() var got []string for rows.Next() { var row string if err := rows.Scan(&row); err != nil { t.Fatal(err) } got = append(got, row) } if err := rows.Err(); err != nil { t.Fatal(err) } if want := []string{"group-1|Beef Stew|u", "group-2|NULL|u"}; strings.Join(got, ",") != strings.Join(want, ",") { t.Errorf("shopping groups after 0019 = %v, want %v", got, want) } if _, err := s.Writer.Exec(`UPDATE shopping_groups SET frozen_dinner_name = '' WHERE id = 'group-1'`); err == nil || !strings.Contains(err.Error(), "CHECK constraint failed") { t.Errorf("empty frozen name: error %v, want CHECK constraint failed", err) } } // TestMigrateSiteNameFromPage applies 0020 over recipes and idea job // results stored when a page naming no site was stored under its host: a // stored name that could be a host — one with no space that is dotted, an // IP address or spelled in the recipe's own link — is cleared, so every // stored name is one a page gave; a name with a space is kept, as is // everything else in the rows. func TestMigrateSiteNameFromPage(t *testing.T) { ctx := context.Background() s := openTestStore(t) migrateBefore(t, s, "0020") sites := []struct { stored any link string want any }{ {"private-token.example.com", "https://private-token.example.com/stew", nil}, {"redirect_token.example.net", "https://kitchen.example/stew", nil}, {"bücher.example", "https://kitchen.example/stew", nil}, {"Food.com", "https://www.food.com/stew", nil}, {"203.0.113.7", "https://203.0.113.7/stew", nil}, {"2001:db8::1", "https://[2001:db8::1]/stew", nil}, {"TokenHost", "https://www.tokenhost/stew", nil}, {"Delish", "https://www.delish.com/stew", nil}, {"Delish", "https://kitchen.example/stew", "Delish"}, {"Curry House", "https://curry-house.example/stew", "Curry House"}, {"Mr. Food Test Kitchen", "https://kitchen.example/stew", "Mr. Food Test Kitchen"}, {nil, "https://kitchen.example/stew", nil}, } for i, c := range sites { if _, err := s.Writer.ExecContext(ctx, `INSERT INTO recipes (id, source_url, site_name, title, raw_jsonld, fetched_at, created_at, updated_at) VALUES (?, ?, ?, 'Stew', '{}', 'f', 'c', 'u')`, fmt.Sprintf("recipe-%d", i), fmt.Sprintf("%s?row=%d", c.link, i), c.stored); err != nil { t.Fatal(err) } } const ( legacy = `{"stage":"done","ideas":[{"name":"A","site_name":"query-host.example","source_url":"https://query-host.example/a?t=1"},{"name":"B","site_name":"Curry House","source_url":"https://b.example/b"},{"name":"C","site_name":null,"source_url":null},{"name":"D","site_name":"Kitchen","source_url":"https://kitchen.example/d"}],"dropped":1}` cleaned = `{"stage":"done","ideas":[{"name":"A","site_name":null,"source_url":"https://query-host.example/a?t=1"},{"name":"B","site_name":"Curry House","source_url":"https://b.example/b"},{"name":"C","site_name":null,"source_url":null},{"name":"D","site_name":null,"source_url":"https://kitchen.example/d"}],"dropped":1}` other = `{"ideas":[{"site_name":"host.example"}]}` ) for _, j := range [][3]string{ {"job-ideas", "ideas_from_ingredients", legacy}, {"job-quick", "quick_ideas", legacy}, {"job-other", "ground_dinner", other}, {"job-empty", "quick_ideas", `{"stage":"searching","ideas":[]}`}, } { if _, err := s.Writer.ExecContext(ctx, `INSERT INTO jobs (id, kind, status, payload, result, created_at, updated_at) VALUES (?, ?, 'succeeded', '{}', ?, 'c', 'u')`, j[0], j[1], j[2]); err != nil { t.Fatal(err) } } if _, err := s.Writer.ExecContext(ctx, `INSERT INTO jobs (id, kind, status, payload, created_at, updated_at) VALUES ('job-running', 'quick_ideas', 'running', '{}', 'c', 'u')`); err != nil { t.Fatal(err) } if err := Migrate(ctx, s.Writer, migrations.FS); err != nil { t.Fatal(err) } for i, c := range sites { var got any var title string if err := s.Reader.QueryRowContext(ctx, `SELECT site_name, title FROM recipes WHERE id = ?`, fmt.Sprintf("recipe-%d", i)).Scan(&got, &title); err != nil { t.Fatal(err) } if got != c.want || title != "Stew" { t.Errorf("recipe stored with site_name %v: site_name %v, title %q after 0020; want %v, Stew", c.stored, got, title, c.want) } } for id, want := range map[string]any{"job-ideas": cleaned, "job-quick": cleaned, "job-other": other, "job-empty": `{"stage":"searching","ideas":[]}`, "job-running": nil} { var got any if err := s.Reader.QueryRowContext(ctx, `SELECT result FROM jobs WHERE id = ?`, id).Scan(&got); err != nil { t.Fatal(err) } if got != want { t.Errorf("%s result after 0020 = %v, want %v", id, got, want) } } }