Fix docker build: move dedupe cases fixture into web #99

2026-10-06T21:37:38-04:00

2026-10-06 21:37:38 -04:00

Maestro task: 3eee9f68-2d34-4e49-8ca5-43bacfb642f0 - Fix docker build: web test imports a fixture outside the web build context.
Done-condition: docker build . completes successfully.

web/src/dinners/names.test.ts imported internal/ai/harness/testdata/dedupe_cases.json, which is
outside the web build context the Dockerfile's web stage copies (COPY web/ ./). So tsc failed
with TS2307 inside npm run build, and docker build . failed with it. Gitea CI does not run
docker build ., which is why the merged feature head was green.

Changes:

Moved the single case file to web/src/dinners/testdata/dedupe_cases.json (git mv, contents
unchanged; still exactly one copy).
names.test.ts imports ./testdata/dedupe_cases.json; the names.ts comment is updated.
internal/ai/harness/dedupe_test.go reads ../../../web/src/dinners/testdata/dedupe_cases.json,
as TestLetterFoldsMatchPWA already reads letterFolds.json. Same cases, same assertions, same
guard that the file has cases.
docs/ARCHITECTURE.md path reference updated.
No Dockerfile or CI changes.

Verified: docker build . exit 0; npm run typecheck && npm test && npm run build (535 tests);
gofmt -l . empty; go vet ./...; go test -race -count=1 ./...; CGO_ENABLED=0 go build ./...;
make sqlc-check with no drift.

Maestro task: `3eee9f68-2d34-4e49-8ca5-43bacfb642f0` - Fix docker build: web test imports a fixture outside the web build context. Done-condition: `docker build .` completes successfully. `web/src/dinners/names.test.ts` imported `internal/ai/harness/testdata/dedupe_cases.json`, which is outside the web build context the Dockerfile's web stage copies (`COPY web/ ./`). So `tsc` failed with TS2307 inside `npm run build`, and `docker build .` failed with it. Gitea CI does not run `docker build .`, which is why the merged feature head was green. Changes: - Moved the single case file to `web/src/dinners/testdata/dedupe_cases.json` (`git mv`, contents unchanged; still exactly one copy). - `names.test.ts` imports `./testdata/dedupe_cases.json`; the `names.ts` comment is updated. - `internal/ai/harness/dedupe_test.go` reads `../../../web/src/dinners/testdata/dedupe_cases.json`, as `TestLetterFoldsMatchPWA` already reads `letterFolds.json`. Same cases, same assertions, same guard that the file has cases. - `docs/ARCHITECTURE.md` path reference updated. - No Dockerfile or CI changes. Verified: `docker build .` exit 0; `npm run typecheck && npm test && npm run build` (535 tests); `gofmt -l .` empty; `go vet ./...`; `go test -race -count=1 ./...`; `CGO_ENABLED=0 go build ./...`; `make sqlc-check` with no drift.

orchestrator-agent added 1 commit 2026-10-06 21:37:38 -04:00

Move dedupe cases fixture into web so docker build can see it

CI / ci (push) Successful in 2m27s

Details

CI / ci (pull_request) Successful in 2m24s

Details

39a251ec69

The PWA's names.test.ts imported internal/ai/harness/testdata/dedupe_cases.json,
which is outside the web build context the Dockerfile's web stage copies, so
tsc failed and docker build . failed. The single case file now lives at
web/src/dinners/testdata/dedupe_cases.json; the harness Go test reads it from
there, as TestLetterFoldsMatchPWA already reads letterFolds.json.

Maestro task: 3eee9f68-2d34-4e49-8ca5-43bacfb642f0

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

review_agent approved these changes

2026-10-06 21:40:25 -04:00

review_agent left a comment

Independent Codex gpt-6-sol review: APPROVED for this exact commit.

approver_agent merged commit a3648397ee into dev

2026-10-06 21:51:48 -04:00

orchestrator-agent referenced this pull request

2026-10-06 21:52:25 -04:00

Promote dev to main: Feature 12 (regular dinners and onboarding) #98

Sign in to join this conversation.