Maniacs_Mansion/MealQuest
11
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Settings home screen (mock 1p) #81

Merged
approver_agent merged 2 commits from task/settings-home_97b50e29-b8a7-4e99-918d-99fa1b239313 into feature/b28d9979-0f7a-4e81-bdff-2f16f3db2053-settings-admin-ai 2026-10-06 09:50:18 -04:00
Conversation 3 Commits 2 Files Changed 10
+846 -7
dev_agent commented 2026-10-06 09:26:25 -04:00
Member
Copy Link
Copy Source

Maestro task: 97b50e29-b8a7-4e99-918d-99fa1b239313 (Feature 11 - Settings Home and Admin AI Assistant).

Done-condition

/settings renders mock 1p: title Settings; teal-100 household banner with 44px avatar, Our kitchen, Shared household - changes apply to everyone; grouped surface cards (radius 26) with 38px round icons and chevrons - HOUSEHOLD: Regular dinners (N on rotation, live count), Google Calendar (live status), Household (timezone and dinner time); ALERTS: Notifications & Google Chat; ADMIN: AI assistant (Anthropic - Claude Sonnet from live settings) with an Admin tag and grape-300 inset ring. Each row navigates to its route. Vitest tests with stubbed APIs assert live status lines and navigation. Typecheck, test and build pass.

Evidence

  • New settings home screen; status lines from household settings, regulars count, Google integration status and the AI settings API; empty/unknown states where an endpoint does not exist yet.
  • npm run lint:colors, typecheck, test (31 files, 355 tests incl. 21 new settings tests covering status lines, navigation for all five rows, 44px tap targets, the Admin ring, Retry and invalid data), build all pass; gofmt -l . empty.
  • Loaded /settings in headless Chrome with stubbed APIs at 360px and 1280px; mobile matches 1p and the desktop sidebar shell works.
Maestro task: 97b50e29-b8a7-4e99-918d-99fa1b239313 (Feature 11 - Settings Home and Admin AI Assistant). ## Done-condition /settings renders mock 1p: title Settings; teal-100 household banner with 44px avatar, Our kitchen, Shared household - changes apply to everyone; grouped surface cards (radius 26) with 38px round icons and chevrons - HOUSEHOLD: Regular dinners (N on rotation, live count), Google Calendar (live status), Household (timezone and dinner time); ALERTS: Notifications & Google Chat; ADMIN: AI assistant (Anthropic - Claude Sonnet from live settings) with an Admin tag and grape-300 inset ring. Each row navigates to its route. Vitest tests with stubbed APIs assert live status lines and navigation. Typecheck, test and build pass. ## Evidence - New settings home screen; status lines from household settings, regulars count, Google integration status and the AI settings API; empty/unknown states where an endpoint does not exist yet. - npm run lint:colors, typecheck, test (31 files, 355 tests incl. 21 new settings tests covering status lines, navigation for all five rows, 44px tap targets, the Admin ring, Retry and invalid data), build all pass; gofmt -l . empty. - Loaded /settings in headless Chrome with stubbed APIs at 360px and 1280px; mobile matches 1p and the desktop sidebar shell works.
dev_agent added 1 commit 2026-10-06 09:26:25 -04:00
Add the settings home screen (mock 1p)
CI / ci (push) Successful in 1m57s
Details
CI / ci (pull_request) Successful in 1m55s
Details
ef1bfcbf01 
/settings now renders the Settings home: the "Our kitchen" shared
household banner and grouped cards for Household (Regular dinners,
Google Calendar, Household), Alerts (Notifications & Google Chat) and
Admin (AI assistant, with the Admin tag and grape-300 inset ring). Each
row links to its settings page.

The Household row shows the live timezone and dinner time from
GET /api/v1/settings/household, and the AI assistant row the live
provider and model from GET /api/v1/settings/ai. Regular dinners,
Google Calendar and Notifications show no status line: the server has
no dinners, Google Calendar or notification endpoint yet.

Shell tests now render the routes inside the API and query providers.

Maestro task: 97b50e29-b8a7-4e99-918d-99fa1b239313

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
overseer added 1 commit 2026-10-06 09:26:25 -04:00
Add the settings home screen (mock 1p)
CI / ci (push) Successful in 1m57s
Details
CI / ci (pull_request) Successful in 1m55s
Details
ef1bfcbf01 
/settings now renders the Settings home: the "Our kitchen" shared
household banner and grouped cards for Household (Regular dinners,
Google Calendar, Household), Alerts (Notifications & Google Chat) and
Admin (AI assistant, with the Admin tag and grape-300 inset ring). Each
row links to its settings page.

The Household row shows the live timezone and dinner time from
GET /api/v1/settings/household, and the AI assistant row the live
provider and model from GET /api/v1/settings/ai. Regular dinners,
Google Calendar and Notifications show no status line: the server has
no dinners, Google Calendar or notification endpoint yet.

Shell tests now render the routes inside the API and query providers.

Maestro task: 97b50e29-b8a7-4e99-918d-99fa1b239313

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
review_agent requested changes 2026-10-06 09:28:40 -04:00
Dismissed
review_agent left a comment
Member
Copy Link
Copy Source

Independent Codex gpt-6-sol review: CHANGES_REQUIRED for this exact commit.

Independent Codex gpt-6-sol review: CHANGES_REQUIRED for this exact commit.
overseer added 1 commit 2026-10-06 09:37:44 -04:00
Show every settings home status line (mock 1p review fixes)
CI / ci (pull_request) Successful in 1m56s
Details
CI / ci (push) Successful in 1m55s
Details
04f12f52b9 
The Regular dinners, Google Calendar and Notifications & Google Chat rows
now show status lines and read them from the server:

- Regular dinners: "N on rotation" from GET /api/v1/dinners?status=regular
  (Feature 12). Until that endpoint exists the server answers 404 and the
  row says "Rotation count unavailable"; no count is invented.
- Google Calendar: "Connected · <calendar name>" from
  GET /api/v1/settings/calendar (Feature 16). Until then a 404 shows the
  truthful "Not connected".
- Notifications & Google Chat: "Push on · <Google Chat space>" from
  GET /api/v1/settings/notifications. Until then a 404 shows
  "Push off · Google Chat not connected".

Only a 404 not_found counts as a missing endpoint; any other failure or a
malformed response shows in the error banner.

The AI assistant row names the model as the handoff does ("Anthropic ·
Claude Sonnet"), shows an unknown model by its id, and says "No model
chosen" for the seeded empty model instead of a trailing separator.

Maestro task: 97b50e29-b8a7-4e99-918d-99fa1b239313

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
review_agent requested changes 2026-10-06 09:39:16 -04:00
Dismissed
review_agent left a comment
Member
Copy Link
Copy Source

Independent Codex gpt-6-sol review: CHANGES_REQUIRED for this exact commit.

Independent Codex gpt-6-sol review: CHANGES_REQUIRED for this exact commit.
review_agent left a comment
Member
Copy Link
Copy Source

Independent Codex gpt-6-sol review: APPROVED for this exact commit.

Independent Codex gpt-6-sol review: APPROVED for this exact commit.
approver_agent merged commit de4f539aea into feature/b28d9979-0f7a-4e81-bdff-2f16f3db2053-settings-admin-ai 2026-10-06 09:50:18 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
review_agent
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
approver_agent (The Approver) chatgpt claude-ai Claude-Code codex (Codex) dev_agent grok opencode orchestrator-agent overseer (Joshua) review_agent (The Reviewer)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Maniacs_Mansion/MealQuest#81