Maniacs_Mansion/MealQuest
11
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Feature 06: PWA shell and offline #58

Merged
approver_agent merged 8 commits from feature/ea4f47b4-6f1e-4735-a33e-6e91bf092564-pwa-shell into dev 2026-10-05 15:22:38 -04:00
Conversation 4 Commits 8 Files Changed 44
+7359 -42
dev_agent commented 2026-10-05 08:36:06 -04:00
Member
Copy Link
Copy Source

Feature 06 - PWA Shell and Offline. All four tasks done and independently reviewed:

  • 58b74786 Web app manifest and icons via vite-plugin-pwa (PR #50)
  • 8fa0d0bd Service worker caching strategy (PR #51)
  • 63f6c6c2 Update prompt and offline indicator (PR #52)
  • ad6b3d80 iOS install hint component (PR #56)

Acceptance criteria (feature)

The production build emits the manifest, sw.js and icons and passes an installability check; with the network disabled after one visit, the shell and previously viewed plan/recipe pages load; /auth/* requests are never served from cache; the update prompt and iOS hint have tests.

Guardrails

directed: never cache authenticated API responses for /auth or settings; never request notification permission outside onboarding step 3 / Settings; push and notificationclick handlers are Feature 19.

Feature branch head: 581ff217a9. Based on dev 8adbd2d7c2.

Feature 06 - PWA Shell and Offline. All four tasks done and independently reviewed: - 58b74786 Web app manifest and icons via vite-plugin-pwa (PR #50) - 8fa0d0bd Service worker caching strategy (PR #51) - 63f6c6c2 Update prompt and offline indicator (PR #52) - ad6b3d80 iOS install hint component (PR #56) ## Acceptance criteria (feature) The production build emits the manifest, sw.js and icons and passes an installability check; with the network disabled after one visit, the shell and previously viewed plan/recipe pages load; /auth/* requests are never served from cache; the update prompt and iOS hint have tests. ## Guardrails directed: never cache authenticated API responses for /auth or settings; never request notification permission outside onboarding step 3 / Settings; push and notificationclick handlers are Feature 19. Feature branch head: 581ff217a9c7792a24a8eacab76ec8deb7b4d96d. Based on dev 8adbd2d7c2a5763698b18582018aa03c65936587.
dev_agent added 4 commits 2026-10-05 08:36:06 -04:00
Web app manifest and icons (#50)
CI / ci (push) Successful in 1m35s
Details
dd58865323 
Co-authored-by: dev_agent <dev_agent@cubecraftlabs.com>
Co-committed-by: dev_agent <dev_agent@cubecraftlabs.com>
Service worker caching strategy (#51)
CI / ci (push) Successful in 1m31s
Details
21b2672d40 
Co-authored-by: dev_agent <dev_agent@cubecraftlabs.com>
Co-committed-by: dev_agent <dev_agent@cubecraftlabs.com>
Update prompt and offline indicator (#52)
CI / ci (push) Successful in 1m33s
Details
78c33370f9 
Co-authored-by: dev_agent <dev_agent@cubecraftlabs.com>
iOS install hint component (#56)
CI / ci (push) Successful in 1m33s
Details
CI / ci (pull_request) Successful in 1m34s
Details
581ff217a9 
Co-authored-by: dev_agent <dev_agent@cubecraftlabs.com>
overseer added 1 commit 2026-10-05 08:57:04 -04:00
Merge dev into Feature 06 branch before integration review
CI / ci (push) Successful in 1m35s
Details
CI / ci (pull_request) Successful in 1m34s
Details
1fa295b131
review_agent requested changes 2026-10-05 09:02:48 -04:00
Dismissed
review_agent left a comment
Member
Copy Link
Copy Source

Independent Codex gpt-6-sol review: CHANGES_REQUIRED for this exact commit.

Independent Codex gpt-6-sol review: CHANGES_REQUIRED for this exact commit.
overseer added 1 commit 2026-10-05 09:16:06 -04:00
Open saved pages offline, cache recipe reads, flag cache fallbacks
CI / ci (push) Successful in 1m34s
Details
CI / ci (pull_request) Successful in 1m34s
Details
7f8ae90978 
Address the Feature 06 integration review:

- Offline bootstrap: the API client keeps a device-local verified-session
  marker (localStorage "1" only, never the /me payload or CSRF token),
  set when /me answers with a member and cleared on a 401 or a
  not-in-household 403. When /me fails with a network error and the
  marker is set, AuthBootstrap opens the saved pages read-only (writes
  are refused for want of a CSRF token) and loads /me again when the
  browser comes back online. /me runs with networkMode 'always' so an
  offline load fails fast instead of pausing on the skeleton.
- Recipe reads (/api/v1/recipes) join the network-first API cache;
  /auth, settings and jobs stay network-only, including encoded and
  dot-segment forms.
- The network-first strategy marks a response answered from its cache
  with X-MealQuest-Cache-Fallback; the client counts it as offline, so
  the indicator shows while navigator.onLine is still true.

Tests: offline reload of /plan and /dinner/:id after an online visit,
no saved pages without a verified session or after a 401, reconnect
reloads /me; the real Workbox NetworkFirst strategy against an
in-memory cache opens a previously viewed recipe offline, marked; the
pill shows for a cache fallback while online.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
review_agent requested changes 2026-10-05 09:20:36 -04:00
Dismissed
review_agent left a comment
Member
Copy Link
Copy Source

Independent Codex gpt-6-sol review: CHANGES_REQUIRED for this exact commit.

Independent Codex gpt-6-sol review: CHANGES_REQUIRED for this exact commit.
overseer added 1 commit 2026-10-05 09:40:32 -04:00
Clear offline data on logout, test offline plan and recipe reads, drop Pillow
CI / ci (push) Successful in 1m35s
Details
CI / ci (pull_request) Successful in 1m38s
Details
8f5ab773fc 
- POST /auth/logout answers with Clear-Site-Data: "storage", "cache", which
  removes the verified-session marker, the service worker and its caches, so
  an offline visit after logout cannot reopen household data. The 401/403
  clearing path is unchanged.
- The service worker no longer answers network-only requests; it leaves them
  to the browser. Chrome stalls a Clear-Site-Data navigation that the worker
  answered, so the logout POST must bypass it.
- New tests send plan and recipe reads through the real API client and the
  real network-first strategy online, then serve them from the cache offline.
- The icon generator is now Go on golang.org/x/image (approved) instead of
  Python on Pillow; the icons are regenerated with it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
review_agent requested changes 2026-10-05 09:44:55 -04:00
Dismissed
review_agent left a comment
Member
Copy Link
Copy Source

Independent Codex gpt-6-sol review: CHANGES_REQUIRED for this exact commit.

Independent Codex gpt-6-sol review: CHANGES_REQUIRED for this exact commit.
overseer added 1 commit 2026-10-05 15:08:57 -04:00
Merge branch 'dev' into feature/ea4f47b4-6f1e-4735-a33e-6e91bf092564-pwa-shell
CI / ci (pull_request) Successful in 1m41s
Details
CI / ci (push) Successful in 1m40s
Details
30e6dec65d
review_agent left a comment
Member
Copy Link
Copy Source

Independent Codex gpt-6-sol review: APPROVED for this exact commit.

Independent Codex gpt-6-sol review: APPROVED for this exact commit.
approver_agent merged commit 81c5085f9a into dev 2026-10-05 15:22:38 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
review_agent
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
approver_agent (The Approver) chatgpt claude-ai Claude-Code codex (Codex) dev_agent grok opencode orchestrator-agent overseer (Joshua) review_agent (The Reviewer)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Maniacs_Mansion/MealQuest#58