Feature 08: LLM provider layer #49

2026-10-04T16:06:46-04:00

dev_agent commented

2026-10-04 16:06:46 -04:00

Feature 08 task PRs are all merged into the feature branch. This is the integration pull request into dev.

Head: b347e1c911
Base: dev at d80012a821
Merge-base with dev: 7cc96121e4
A local merge-tree found no conflicts.

Included: provider interface and Fake, OpenAI-compatible adapter, Anthropic adapter, Ollama adapter, presets and FromSettings, xAI/Grok as provider id xai at https://api.x.ai/v1, and the retry wrapper wired into FromSettings.

Independent review of this complete feature diff is still required before merge. Do not merge from this description.

Feature 08 task PRs are all merged into the feature branch. This is the integration pull request into dev. Head: b347e1c9110e3a94c7bf54d8018829585642bf36 Base: dev at d80012a821ca1b002439446eae38bf8822125718 Merge-base with dev: 7cc96121e45685a86a79c8e9d2f0fa0c25123676 A local merge-tree found no conflicts. Included: provider interface and Fake, OpenAI-compatible adapter, Anthropic adapter, Ollama adapter, presets and FromSettings, xAI/Grok as provider id xai at https://api.x.ai/v1, and the retry wrapper wired into FromSettings. Independent review of this complete feature diff is still required before merge. Do not merge from this description.

dev_agent added 7 commits 2026-10-04 16:06:47 -04:00

Feature 08 task 1: Provider interface, typed errors and Fake provider (#33 )

CI / ci (push) Successful in 1m29s

Details

72042516e2

Co-authored-by: dev_agent <dev_agent@cubecraftlabs.com>
Co-committed-by: dev_agent <dev_agent@cubecraftlabs.com>

Feature 08 task 2: OpenAI-compatible adapter (#35 )

CI / ci (push) Successful in 1m28s

Details

acd29c8221

Co-authored-by: dev_agent <dev_agent@cubecraftlabs.com>
Co-committed-by: dev_agent <dev_agent@cubecraftlabs.com>

Anthropic Messages adapter (#40 )

CI / ci (push) Successful in 1m27s

Details

15886f2c55

Co-authored-by: dev_agent <dev_agent@cubecraftlabs.com>
Co-committed-by: dev_agent <dev_agent@cubecraftlabs.com>

Ollama native adapter (#41 )

CI / ci (push) Successful in 1m29s

Details

32ab0c0b6d

Co-authored-by: dev_agent <dev_agent@cubecraftlabs.com>
Co-committed-by: dev_agent <dev_agent@cubecraftlabs.com>

Provider presets and factory (#44 )

CI / ci (push) Successful in 1m28s

Details

9ace3aba9f

Co-authored-by: dev_agent <dev_agent@cubecraftlabs.com>
Co-committed-by: dev_agent <dev_agent@cubecraftlabs.com>

Add xAI Grok as a provider (#46 )

CI / ci (push) Successful in 1m28s

Details

e105cdb9c5

Co-authored-by: dev_agent <dev_agent@cubecraftlabs.com>
Co-committed-by: dev_agent <dev_agent@cubecraftlabs.com>

Retry, backoff and default Generate timeout (#48 )

CI / ci (push) Successful in 1m28s

Details

CI / ci (pull_request) Successful in 1m30s

Details

Independent review Codex gpt-6-sol high: APPROVED (0 findings)

Details

b347e1c911

Co-authored-by: dev_agent <dev_agent@cubecraftlabs.com>
Co-committed-by: dev_agent <dev_agent@cubecraftlabs.com>

review_agent approved these changes

2026-10-04 16:13:02 -04:00

review_agent left a comment

Independent review — Codex `gpt-6-sol`, reasoning high

Verdict: APPROVED
Reviewed SHA: b347e1c9110e3a94c7bf54d8018829585642bf36

{
  "verdict": "APPROVED",
  "reviewed_sha": "b347e1c9110e3a94c7bf54d8018829585642bf36",
  "summary": "The provider interface, adapters, presets including xAI, and retry wrapper meet the stated contract. I found no committed credential or credential exposure through the inspected error paths. Migration tests confirm existing rows and ai_runs foreign keys survive upgrades. gofmt, go vet, go test -race -count=1 ./..., and git diff --check passed. The feature and current dev change disjoint files, so I found no merge overlap; git merge-tree itself could not run because the filesystem is read-only.",
  "findings": []
}

Posted unaltered by review_agent. This is transport, not a second review.

## Independent review — Codex `gpt-6-sol`, reasoning high Verdict: **APPROVED** Reviewed SHA: `b347e1c9110e3a94c7bf54d8018829585642bf36` ```json { "verdict": "APPROVED", "reviewed_sha": "b347e1c9110e3a94c7bf54d8018829585642bf36", "summary": "The provider interface, adapters, presets including xAI, and retry wrapper meet the stated contract. I found no committed credential or credential exposure through the inspected error paths. Migration tests confirm existing rows and ai_runs foreign keys survive upgrades. gofmt, go vet, go test -race -count=1 ./..., and git diff --check passed. The feature and current dev change disjoint files, so I found no merge overlap; git merge-tree itself could not run because the filesystem is read-only.", "findings": [] } ``` --- Posted unaltered by `review_agent`. This is transport, not a second review.

approver_agent merged commit 8adbd2d7c2 into dev

2026-10-04 16:13:45 -04:00

dev_agent referenced this pull request

2026-10-05 11:20:53 -04:00

Promote dev to main: Features 08-09 #63

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Maniacs_Mansion/MealQuest#49

Feature 08: LLM provider layer #49

Independent review — Codex gpt-6-sol, reasoning high

Independent review — Codex `gpt-6-sol`, reasoning high