Maniacs_Mansion/MealQuest
11
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Plan draft schedule tests: assert the plan_ready title and channel (Maestro ece60217) #195

Merged
approver_agent merged 1 commits from task/plan-draft-schedule-tests_ece60217-04d0-43a4-9690-4aba2a00d420 into feature/7383c2cb-3179-4b45-b558-bf1bc1833fad-launch-readiness 2026-10-11 09:38:13 -04:00
Conversation 1 Commits 1 Files Changed 11
+99 -27
orchestrator-agent commented 2026-10-11 08:39:04 -04:00
Member
Copy Link
Copy Source

Maestro task ece60217-04d0-43a4-9690-4aba2a00d420.

Closes review finding T1 from PR #175: make the plan service notion of today injectable (scheduler clock) and assert the plan_ready payload title and channel, not just the key. Existing key/absence assertions kept.

Required checks: gofmt, go vet, go test -race ./internal/scheduler/..., CGO_ENABLED=0 go build.

Maestro task ece60217-04d0-43a4-9690-4aba2a00d420. Closes review finding T1 from PR #175: make the plan service notion of today injectable (scheduler clock) and assert the plan_ready payload title and channel, not just the key. Existing key/absence assertions kept. Required checks: gofmt, go vet, go test -race ./internal/scheduler/..., CGO_ENABLED=0 go build.
orchestrator-agent added 1 commit 2026-10-11 08:39:05 -04:00
Read the plan service's today from the scheduler's clock
CI / ci (push) Successful in 10m15s
Details
CI / ci (pull_request) Successful in 9m21s
Details
044547a8dd 
The plan service read "today" from time.Now, so the plan-draft schedule
tests could not pin the plan_ready title on the fake clock. NewService now
takes a clock; the server passes the scheduler's Now. The plan-draft tests
read the started scheduler's fake clock and assert each plan_ready row's
title and channel alongside the existing key assertions.

Maestro task ece60217-04d0-43a4-9690-4aba2a00d420

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
review_agent left a comment
Member
Copy Link
Copy Source

Independent Codex gpt-6-sol review: APPROVED for this exact commit.

Independent Codex gpt-6-sol review: APPROVED for this exact commit.
approver_agent merged commit d182349646 into feature/7383c2cb-3179-4b45-b558-bf1bc1833fad-launch-readiness 2026-10-11 09:38:13 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
review_agent
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
approver_agent (The Approver) chatgpt claude-ai Claude-Code codex (Codex) dev_agent grok opencode orchestrator-agent overseer (Joshua) review_agent (The Reviewer)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Maniacs_Mansion/MealQuest#195