Add make build to embed the built PWA in the server binary
Independent review Not signed off — 0 high, 1 medium (#4)
Independent review Not signed off — 0 high, 1 medium (#4)
Fixes review finding F1: nothing copied web/dist into internal/frontend/dist, so the server always embedded the placeholder. make build now builds the web app, replaces internal/frontend/dist with web/dist, and builds bin/mealquest. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -8,6 +8,7 @@ deploy/secrets/
|
|||||||
# Build artifacts and dependencies
|
# Build artifacts and dependencies
|
||||||
node_modules
|
node_modules
|
||||||
dist
|
dist
|
||||||
|
bin/
|
||||||
# Placeholder so the Go embed compiles on a fresh clone; built assets stay ignored.
|
# Placeholder so the Go embed compiles on a fresh clone; built assets stay ignored.
|
||||||
!internal/frontend/dist/
|
!internal/frontend/dist/
|
||||||
internal/frontend/dist/*
|
internal/frontend/dist/*
|
||||||
|
|||||||
@@ -0,0 +1,16 @@
|
|||||||
|
# Build entry point: build the PWA, embed it, then build the server binary.
|
||||||
|
|
||||||
|
FRONTEND_DIST := internal/frontend/dist
|
||||||
|
|
||||||
|
.PHONY: build web embed
|
||||||
|
|
||||||
|
build: embed
|
||||||
|
go build -o bin/mealquest ./cmd/server
|
||||||
|
|
||||||
|
web:
|
||||||
|
cd web && npm ci && npm run build
|
||||||
|
|
||||||
|
# Replace the committed placeholder with the built PWA so go:embed picks it up.
|
||||||
|
embed: web
|
||||||
|
rm -rf $(FRONTEND_DIST)/*
|
||||||
|
cp -R web/dist/. $(FRONTEND_DIST)/
|
||||||
Reference in New Issue
Block a user